phar: Remove confusing dtor calls #20148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If object initialization fails the zval will be NULL, that's an implementation detail. However, it's very confusing for a reader to destroy a seemingly uninitialized zval.
devnexen
approved these changes
Oct 12, 2025
Girgias
reviewed
Oct 12, 2025
Comment on lines
1747
to
1754
| if (SUCCESS != object_init_ex(&iteriter, spl_ce_RecursiveIteratorIterator)) { | ||
| zval_ptr_dtor(&iter); | ||
| zval_ptr_dtor(&iteriter); | ||
| zend_throw_exception_ex(spl_ce_BadMethodCallException, 0, "Unable to instantiate directory iterator for %s", phar_obj->archive->fname); | ||
| RETURN_THROWS(); | ||
| } | ||
|
|
||
| zend_call_known_instance_method_with_1_params(spl_ce_RecursiveIteratorIterator->constructor, | ||
| Z_OBJ(iteriter), NULL, &iter); |
There was a problem hiding this comment.
Follow-up idea maybe use the newish object_init_with_constructor() API? (and similarly for the above case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If object initialization fails the zval will be NULL, that's an implementation detail. However, it's very confusing for a reader to destroy a seemingly uninitialized zval.