phar: Use object_init_with_constructor where possible #20156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could also chain the exceptions, but the current code keeps the existing behaviour by adding EG(exception) checks.
Girgias
reviewed
Oct 12, 2025
ext/phar/phar_object.c
Outdated
Comment on lines
1737
to
1739
| if (!EG(exception)) { | ||
| zend_throw_exception_ex(spl_ce_BadMethodCallException, 0, "Unable to instantiate directory iterator for %s", phar_obj->archive->fname); | ||
| } |
There was a problem hiding this comment.
Is it possible to not have an exception?
There was a problem hiding this comment.
Heh, yeah I think you're right. Time to drop more code!
There was a problem hiding this comment.
Sometimes I design reasonable APIs :p
Girgias
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also chain the exceptions, but the current code keeps the existing behaviour by adding EG(exception) checks.