Fix GH-20189: Tempnam notice message incorrect #20191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notice was outputted before the creation of the file even took place. Therefore, if the creation of the file fails, the notice is outputted while it shouldn't have been. This changes one test which indeed suffered from this issue due to the open_basedir restriction.
The function returned false, this should've never been outputted in the first place.
TimWolla
reviewed
Oct 17, 2025
| if (fd == -1) { | ||
| /* Use default temporary directory. */ | ||
| if (!(flags & PHP_TMP_FILE_SILENT)) { | ||
| php_error_docref(NULL, E_NOTICE, "file created in the system's temporary directory"); |
There was a problem hiding this comment.
Alternatively perhaps just:
file will be created […]
Looking at ext/standard/tests/file/bug52624.phpt folks might otherwise be confused why the final error message mentions /tmp.
There was a problem hiding this comment.
I see what you mean. I'm undecided yet, hence also the TODO I put
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notice was outputted before the creation of the file even took place. Therefore, if the creation of the file fails, the notice is outputted while it shouldn't have been.
This changes one test which indeed suffered from this issue due to the open_basedir restriction.