PHP 8.5 | UPGRADING: add missing entries for FILTER_THROW_ON_FAILURE RFC #20237
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the changelog entry (and possibly NEWS too?) was missed completely for this RFC. Refs: * https://wiki.php.net/rfc/filter_throw_on_failure * php@0b326dc
jrfnl
force-pushed
the
feature/upgrading-add-missing-changelog-filter
branch
from
c8f3dbb to
5111608
Compare
|
Force push was only removing a stray trailing whitespace. |
|
Good catch, sorry I missed this - I'll merge once CI finishes |
|
@DanielEScherzer Happens to the best of us. Expect a few more PRs like this over the next weeks as I've already spotted more things missing. |
DanielEScherzer
added a commit
that referenced
this pull request
Oct 19, 2025
* PHP-8.5: PHP 8.5 | UPGRADING: add missing entries for FILTER_THROW_ON_FAILURE RFC (#20237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the changelog entry (and possibly NEWS too?) was missed completely for this RFC.
Refs:
/cc @DanielEScherzer