Fix GH-20240: FTP with SSL: ftp_fput(): Connection timed out on successful writes #20294
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessful writes Looking at the strace, the timeout is only 1s which may be too low anyway for checking for a response, but some servers also don't end up replying finally anyway and close the connection already. `data_available` was originally used for non-blocking downloads/uploads and then reused for the shutdown sequence, but its error handling was never adjusted to be silent.
devnexen
approved these changes
Oct 26, 2025
Girgias
approved these changes
Oct 26, 2025
Comment on lines
+1616
to
+1618
| if (silent) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
While merging up, the signature of the function was changed, so please make it return false rather than 0 then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the strace, the timeout is only 1s which may be too low anyway for checking for a response, but some servers also don't end up replying finally anyway and close the connection already.
data_availablewas originally used for non-blocking downloads/uploads and then reused for the shutdown sequence, but its error handling was never adjusted to be silent.