Fix GH-20286: use-after-destroy during userland stream_close(). #20348
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
Oct 31, 2025
Zend/zend_execute_API.c
Outdated
| fci.param_count = param_count; | ||
| fci.params = params; | ||
| fci.named_params = NULL; | ||
| if (EG(active)) { |
iluuu1994
reviewed
Oct 31, 2025
iluuu1994
reviewed
Oct 31, 2025
Zend/zend_execute_API.c
Outdated
| uint32_t param_count, zval *params) | ||
| { | ||
| if (UNEXPECTED(!EG(active))) { | ||
| #ifdef ZEND_DEBUG |
There was a problem hiding this comment.
Should be #if rather than #ifdef, ZEND_DEBUG always declared in main/php_config.h but may be 0.
| #ifdef ZEND_DEBUG | ||
| ZEND_UNREACHABLE(); | ||
| #endif | ||
| return FAILURE; |
There was a problem hiding this comment.
There should probably be a ZVAL_UNDEF(retval); as below.
iluuu1994
reviewed
Nov 1, 2025
|
|
||
| if (UNEXPECTED(stream->wrapper->wops != &user_stream_wops)) { | ||
| stream->wrapper->wops = &user_stream_wops; | ||
| } |
There was a problem hiding this comment.
This looks a bit odd, why is this necessary?
There was a problem hiding this comment.
Program received signal SIGSEGV, Segmentation fault.
0x0000555555aa0f35 in _php_stream_free (stream=<optimized out>, close_options=close_options@entry=11) at /home/dcarlier/Contribs/php-src/main/streams/streams.c:505
505 stream->wrapper->wops->stream_closer(stream->wrapper, stream);
(gdb) p *stream->wrapper->wops
$2 = {stream_opener = 0x7ffff767be60, stream_closer = 0xc0d29af9ee47b9cc, stream_stat = 0xb, url_stat = 0x735f6d6165727473, dir_opener = 0x6f69747000746174,
label = 0x6e <error: Cannot access memory at address 0x6e>, unlink = 0x0, rename = 0x5555568bc500, stream_mkdir = 0x0, stream_rmdir = 0x5a0, stream_metadata = 0x7ffff767beb0}
(gdb) p *stream->wrapper->wops->stream_closer
Cannot access memory at address 0xc0d29af9ee47b9cc
(gdb)| --FILE-- | ||
| <?php | ||
| class lib { | ||
| function stream_open() { |
| ?> | ||
| --EXPECTF-- | ||
|
|
||
| Deprecated: Creation of dynamic property lib::$context is deprecated in %s on line %d |
There was a problem hiding this comment.
Maybe create the $context prop and create empty stubs for these functions to make the warnings go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.