Skip to content

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Nov 11, 2025

No description provided.

@ndossche
Copy link
Member

While this makes things more consistent ,I think this is the wrong approach. I'll reply in the issue thread to not split the discussion over 2 different places.

Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this should be a part of 8.5.0RC5 it needs to target 8.5 rather than master
Since 8.5.0 is already branched, RM approval is no longer needed, RM approval is implicit if/when we cherry-pick to the 8.5.0 branch
But, given the discussion on #20384, I've also taken a look - RM approval, technical review not performed

@DanielEScherzer DanielEScherzer changed the base branch from master to PHP-8.5 November 11, 2025 18:27
@DanielEScherzer
Copy link
Member

DanielEScherzer commented Nov 11, 2025

Closing and reopening to hopefully rerun GitHub actions now that the target branch has changed, c.f. https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request

For example, if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated.

@bukka
Copy link
Member

bukka commented Nov 11, 2025

I agree that this is a wrong approach - see the comments in other threads.

@DanielEScherzer
Copy link
Member

Cross link #20455
Closing this now just so that we don't accidentally merge it, we should probably eventually restore the deprecation on master and apply this

@Girgias Girgias deleted the 8.5-ob_gzhandle branch November 12, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants