Skip to content

Revert "Deprecate returning non-string values from a user output handler (#18932)" #20455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2025
Merged

Revert "Deprecate returning non-string values from a user output handler (#18932)" #20455

merged 3 commits into from
Nov 11, 2025

Conversation

@DanielEScherzer
Copy link
Member

@DanielEScherzer DanielEScherzer commented Nov 11, 2025

This reverts commit d8577d9.

@DanielEScherzer
Copy link
Member Author

DanielEScherzer commented Nov 11, 2025 •
edited
Loading

Not an exact revert

  • the logic about tracking the output handler is kept, since it is also used for the deprecation warnings about producing output (07f1cfd)
  • the unrelated tests that were updated to have their output handlers return strings are not reverted
  • tests from 07f1cfd when both warnings are emitted are also deleted

@DanielEScherzer DanielEScherzer requested review from Girgias, bukka and ndossche and removed request for bukka November 11, 2025 19:15
@DanielEScherzer DanielEScherzer linked an issue Nov 11, 2025 that may be closed by this pull request
Confirm if ob_gzhandler is impacted by ob_start handler changes #20384
Closed
@DanielEScherzer DanielEScherzer mentioned this pull request Nov 11, 2025
Closed
ndossche
ndossche approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@ndossche ndossche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically fine. Would need a clarifying NEWS entry.

@DanielEScherzer
Copy link
Member Author

DanielEScherzer commented Nov 11, 2025

Given that the original deprecation wasn't noted in NEWS, just UPGRADING, I don't think we need an entry in the overall PHP-8.5 NEWS. I'll add one to the RC5 NEWS when I cherry-pick

@DanielEScherzer DanielEScherzer merged commit 2711864 into php:PHP-8.5 Nov 11, 2025
10 checks passed
DanielEScherzer added a commit that referenced this pull request Nov 11, 2025
@DanielEScherzer
Merge branch 'PHP-8.5'
3747e93 
* PHP-8.5:
  Revert "Deprecate returning non-string values from a user output handler (#18932)" (#20455)
@DanielEScherzer DanielEScherzer deleted the revert-output-handler-return branch November 11, 2025 23:24
DanielEScherzer added a commit that referenced this pull request Nov 12, 2025
@DanielEScherzer
Revert "Deprecate returning non-string values from a user output hand…
23b6b0d 
…ler (#18932)" (#20455)

This partially reverts commit d8577d9, and
reverts parts of 07f1cfd.

(cherry picked from commit 2711864)
DanielEScherzer added a commit to DanielEScherzer/doc-en that referenced this pull request Nov 12, 2025
@DanielEScherzer
PHP 8.5 deprecations: remove output handler return deprecation
987f66e 
Deprecation was reverted, see php/php-src#20455
This was referenced Nov 12, 2025
Merged
Open
Girgias pushed a commit to php/doc-en that referenced this pull request Nov 12, 2025
@DanielEScherzer
PHP 8.5 deprecations: remove output handler return deprecation (#4992)
2def8c3 
Deprecation was reverted, see php/php-src#20455
@Marqitos Marqitos mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndossche ndossche ndossche approved these changes

@Girgias Girgias Awaiting requested review from Girgias

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confirm if ob_gzhandler is impacted by ob_start handler changes

2 participants

@DanielEScherzer @ndossche