phar: Fix broken return value of fflush() for phar file entries #20474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flush functions always return EOF, even in the success path. The success path should return 0 to indicate success.
devnexen
approved these changes
Nov 13, 2025
Girgias
approved these changes
Nov 14, 2025
staabm
reviewed
Nov 14, 2025
| @@ -0,0 +1,25 @@ | |||
| --TEST-- | |||
Contributor
There was a problem hiding this comment.
the 2 tests contain identical contents.. did you miss to alter one of them?
Member
Author
There was a problem hiding this comment.
Oops. What happened is that I was first working on this test, and then noticed the wrong return value.
So then I started writing a test in this file and then did save-as. Which is how we ended up with a duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flush functions always return EOF, even in the success path. The success path should return 0 to indicate success.