mbstring: Fix missing copying of detect_order_list to current_detect_order_list #20523
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToBee94
force-pushed
the
fix-ini-set-mbstring-detect-order-is-ignored
branch
from
abefb0c to
b82312a
Compare
Author
|
@youkidearitai and @alexdowad can you please have a look on it? |
youkidearitai
approved these changes
Nov 28, 2025
Contributor
youkidearitai
left a comment
youkidearitai
left a comment
There was a problem hiding this comment.
Sorry for late, LGTM.
Contributor
|
@ToBee94 I'm very sorry for the delay. I will also try to review today. |
Contributor
|
This looks good! I think the NEWS and UPGRADING files should be updated. |
…order_list on ini_set('mbstring.detect_order', string)
This reverts commit b82312a.
…() with mbstring.detect_order
ToBee94
force-pushed
the
fix-ini-set-mbstring-detect-order-is-ignored
branch
from
c3a07cf to
557f2d3
Compare
Contributor
|
CI failure on macOS is completely unrelated (there's a compile error in |
Author
|
From my side yes, i have no changes planned anymore. Thank you :) |
Contributor
|
@ToBee94, thank you very much for your contribution. And I apologize again that it took a long time to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At investigation of a possible bug in phpunit (sebastianbergmann/phpunit#6417) i found a bug in mbstring.
If you update the mbstring.detect_order with ini_set, the change doesn't affect mb_detect_encoding.