Add "since version" to ReflectionXxx::setAccessible() method deprecation warning #20555
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
requested review from
DanielEScherzer and
kocsismate
as code owners
mvorisek
changed the title
mvorisek
changed the title
DanielEScherzer
approved these changes
Nov 22, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Wearing my ext/reflection maintainer hat: makes total sense
Wearing my 8.5 RM hat
- I think this is okay to change, but please wait for @edorian to also approve this
- For the various no-op closing functions that I implemented the deprecation for, I included the version the function became a no-op, but for
finfo_close()which I didn't implement the message doesn't include the version. Do you want to add it there too?
kocsismate
approved these changes
Nov 22, 2025
edorian
approved these changes
Nov 25, 2025
Member
edorian
left a comment
edorian
left a comment
There was a problem hiding this comment.
No RM objections from my side
Member
|
Okay, I'll merge this tomorrow |
Member
Tomorrow, loosely defined |
DanielEScherzer
added a commit
that referenced
this pull request
Dec 1, 2025
* PHP-8.5: Add "since PHP 8.1" to ReflectionXxx::setAccessible() deprecations (#20555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve #19273
The method is extensively used [1], even small improvement of the deprecation warning is helpful to better understand why it is not needed anymore and since what version.
[1] used almost in every larger project/package