Skip to content

phar: Remove unused min_timestamp field #20617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2025
+2 −9
Merged

phar: Remove unused min_timestamp field #20617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ext/phar/phar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,15 +1149,9 @@ static zend_result phar_parse_pharfile(php_stream *fp, char *fname, size_t fname
PHAR_GET_32(buffer, entry.uncompressed_filesize);
PHAR_GET_32(buffer, entry.timestamp);

if (offset == halt_offset + manifest_len + 4) {
mydata->min_timestamp = entry.timestamp;
if (offset == halt_offset + manifest_len + 4
|| mydata->max_timestamp < entry.timestamp) {
mydata->max_timestamp = entry.timestamp;
} else {
if (mydata->min_timestamp > entry.timestamp) {
mydata->min_timestamp = entry.timestamp;
} else if (mydata->max_timestamp < entry.timestamp) {
mydata->max_timestamp = entry.timestamp;
}
}

PHAR_GET_32(buffer, entry.compressed_filesize);
Expand Down
1 change: 0 additions & 1 deletion ext/phar/phar_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ struct _phar_archive_data {
/* hash of mounted directory paths */
HashTable mounted_dirs;
uint32_t flags;
uint32_t min_timestamp;
uint32_t max_timestamp;
int refcount;
php_stream *fp;
Expand Down
Loading