Improve TypeError messages for non-numeric/empty strings in coercions; Closes #20632 #20639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Dec 4, 2025
mvorisek
reviewed
Dec 4, 2025
Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
iluuu1994
requested changes
Dec 4, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Please also see my comment in #20632 (comment).
…e callers Removed unnecessary changes.
Member
|
I don't know if the code churn is worth it. @Girgias Opinions? |
jorgsowa
reviewed
Jan 17, 2026
| @@ -0,0 +1,35 @@ | |||
| --TEST-- | |||
| Error message for non-numaric strings in arithmetic contexts | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Error message for non-numaric strings in arithmetic contexts | |
| Error message for non-numeric strings in arithmetic contexts |
Girgias
requested changes
Jan 19, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
This is a lot of code churn and I don't even think the implementation is correct vis a vis strict_types.
I'd prefer a discussion on the mailing list, I can understand the rationale somewhat, but an empty string is non-numeric so this seems redundant?
And I'd be more inclined to do this just for binary ops, rather than all type checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposal from #20632