Skip to content

ext/standard: Refactor and add {s|f}scanf tests #20676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Girgias wants to merge 9 commits into
base: master
Choose a base branch
from
Open

ext/standard: Refactor and add {s|f}scanf tests #20676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
570c2eb
ext/standard: Delete fscanf test cases that write arrays to file via …
Girgias Dec 11, 2025
a7dff9c
ext/standard: Delete fscanf test cases that write resources to file v…
Girgias Dec 11, 2025
ec67bbd
ext/standard: Delete fscanf test cases that write objects to file via…
Girgias Dec 11, 2025
e0378f6
ext/standard: Delete fscanf test cases that write bools to file via f…
Girgias Dec 11, 2025
2f13db4
ext/standard: Remove invalid specifier tests for fscanf
Girgias Dec 11, 2025
3889123
ext/standard: Move fscanf tests to subfolder
Girgias Dec 11, 2025
58d7495
ext/standard: Refactor fscanf test using strings
Girgias Dec 11, 2025
a1e9a9a
ext/standard: Move sscanf tests to subfolder
Girgias Dec 9, 2025
6c16086
ext/standard: Add some sscanf tests
Girgias Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ext/standard/tests/file/fscanf.phpt → ext/standard/tests/file/fscanf/fscanf.phpt
View file
Open in desktop
File renamed without changes.
0 ext/standard/tests/file/fscanf_error.phpt → ...ndard/tests/file/fscanf/fscanf_error.phpt
View file
Open in desktop
File renamed without changes.
0 ...tandard/tests/file/fscanf_variation1.phpt → .../tests/file/fscanf/fscanf_variation1.phpt
View file
Open in desktop
File renamed without changes.
310 changes: 59 additions & 251 deletions ...andard/tests/file/fscanf_variation11.phpt → ...tests/file/fscanf/fscanf_variation12.phpt
View file
Open in desktop

Large diffs are not rendered by default.

260 changes: 49 additions & 211 deletions ...andard/tests/file/fscanf_variation14.phpt → ...tests/file/fscanf/fscanf_variation14.phpt
View file
Open in desktop

Large diffs are not rendered by default.

30 changes: 6 additions & 24 deletions ...andard/tests/file/fscanf_variation15.phpt → ...tests/file/fscanf/fscanf_variation15.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $float_values = array (

$string_formats = array( "%s",
"%hs", "%ls", "%Ls",
" %s", "%s ", "% s",
" %s", "%s ",
"\t%s", "\n%s", "%4s",
"%30s", "%[a-zA-Z0-9]", "%*s");

Expand Down Expand Up @@ -463,24 +463,6 @@ array(1) {
bool(false)

-- iteration 7 --
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
bool(false)

-- iteration 8 --
array(1) {
[0]=>
string(11) "-2147483649"
Expand Down Expand Up @@ -543,7 +525,7 @@ array(1) {
}
bool(false)

-- iteration 9 --
-- iteration 8 --
array(1) {
[0]=>
string(11) "-2147483649"
Expand Down Expand Up @@ -606,7 +588,7 @@ array(1) {
}
bool(false)

-- iteration 10 --
-- iteration 9 --
array(1) {
[0]=>
string(4) "-214"
Expand Down Expand Up @@ -669,7 +651,7 @@ array(1) {
}
bool(false)

-- iteration 11 --
-- iteration 10 --
array(1) {
[0]=>
string(11) "-2147483649"
Expand Down Expand Up @@ -732,7 +714,7 @@ array(1) {
}
bool(false)

-- iteration 12 --
-- iteration 11 --
array(1) {
[0]=>
NULL
Expand Down Expand Up @@ -795,7 +777,7 @@ array(1) {
}
bool(false)

-- iteration 13 --
-- iteration 12 --
array(0) {
}
array(0) {
Expand Down
33 changes: 6 additions & 27 deletions ...andard/tests/file/fscanf_variation18.phpt → ...tests/file/fscanf/fscanf_variation18.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ $integer_values = array (

$string_formats = array( "%s",
"%hs", "%ls", "%Ls",
" %s", "%s ", "% s",
" %s", "%s ",
"\t%s", "\n%s", "%4s",
"%30s", "%[a-zA-Z0-9]", "%*s"
);
Expand Down Expand Up @@ -539,27 +539,6 @@ array(1) {
bool(false)

-- iteration 7 --
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
bool(false)

-- iteration 8 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -634,7 +613,7 @@ array(1) {
}
bool(false)

-- iteration 9 --
-- iteration 8 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -709,7 +688,7 @@ array(1) {
}
bool(false)

-- iteration 10 --
-- iteration 9 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -784,7 +763,7 @@ array(1) {
}
bool(false)

-- iteration 11 --
-- iteration 10 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -859,7 +838,7 @@ array(1) {
}
bool(false)

-- iteration 12 --
-- iteration 11 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -934,7 +913,7 @@ array(1) {
}
bool(false)

-- iteration 13 --
-- iteration 12 --
array(0) {
}
array(0) {
Expand Down
35 changes: 7 additions & 28 deletions ...tandard/tests/file/fscanf_variation2.phpt → .../tests/file/fscanf/fscanf_variation2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ $valid_ints = array(
0x7fffffff, // max positive integer as hexadecimal
0x7FFFFFFF, // max positive integer as hexadecimal
0123, // integer as octal
01, // should be quivalent to octal 1
01, // should be equivalent to octal 1
-020000000000, // max negative integer as octal
017777777777 // max positive integer as octal
);
// various integer formats
$int_formats = array( "%d", "%hd", "%ld", "%Ld", " %d", "%d ", "% d", "\t%d", "\n%d", "%4d", "%30d", "%[0-9]", "%*d");
$int_formats = array( "%d", "%hd", "%ld", "%Ld", " %d", "%d ", "\t%d", "\n%d", "%4d", "%30d", "%[0-9]", "%*d");

$counter = 1;

Expand Down Expand Up @@ -533,27 +533,6 @@ array(1) {
bool(false)

-- iteration 7 --
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
bool(false)

-- iteration 8 --
array(1) {
[0]=>
int(0)
Expand Down Expand Up @@ -628,7 +607,7 @@ array(1) {
}
bool(false)

-- iteration 9 --
-- iteration 8 --
array(1) {
[0]=>
int(0)
Expand Down Expand Up @@ -703,7 +682,7 @@ array(1) {
}
bool(false)

-- iteration 10 --
-- iteration 9 --
array(1) {
[0]=>
int(0)
Expand Down Expand Up @@ -778,7 +757,7 @@ array(1) {
}
bool(false)

-- iteration 11 --
-- iteration 10 --
array(1) {
[0]=>
int(0)
Expand Down Expand Up @@ -853,7 +832,7 @@ array(1) {
}
bool(false)

-- iteration 12 --
-- iteration 11 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -928,7 +907,7 @@ array(1) {
}
bool(false)

-- iteration 13 --
-- iteration 12 --
array(0) {
}
array(0) {
Expand Down
33 changes: 6 additions & 27 deletions ...andard/tests/file/fscanf_variation20.phpt → ...tests/file/fscanf/fscanf_variation20.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ $valid_ints = array(
// various char formats
$char_formats = array( "%c",
"%hc", "%lc", "%Lc",
" %c", "%c ", "% c",
" %c", "%c ",
"\t%c", "\n%c", "%4c",
"%30c", "%[a-bA-B@#$&]", "%*c");

Expand Down Expand Up @@ -537,27 +537,6 @@ array(1) {
bool(false)

-- iteration 7 --
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
Bad scan conversion character " "
bool(false)

-- iteration 8 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -632,7 +611,7 @@ array(1) {
}
bool(false)

-- iteration 9 --
-- iteration 8 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -707,7 +686,7 @@ array(1) {
}
bool(false)

-- iteration 10 --
-- iteration 9 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -782,7 +761,7 @@ array(1) {
}
bool(false)

-- iteration 11 --
-- iteration 10 --
array(1) {
[0]=>
string(1) "0"
Expand Down Expand Up @@ -857,7 +836,7 @@ array(1) {
}
bool(false)

-- iteration 12 --
-- iteration 11 --
array(1) {
[0]=>
NULL
Expand Down Expand Up @@ -932,7 +911,7 @@ array(1) {
}
bool(false)

-- iteration 13 --
-- iteration 12 --
array(0) {
}
array(0) {
Expand Down
Loading