ext/standard: Refactor scanf #20682
Draft
ext/standard: Refactor scanf #20682
+1,260
−13,728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…printf This effectively tests scanning an empty file line or a file line only containing '1', which is already handled by the string tests
These are not parsing related
A bunch of the test cases are testing the language scanner rules rather than fscanf
This is in preparation for some major refactoring as the current error messages are non-sensical
And remove relevant now useless sanity checks
This makes the code more obvious
…rameter of ValidateFormat()
… ValidateFormat()
In preparation for better format parsing
In preparation for better format parsing
Girgias
force-pushed
the
scanf-issues
branch
from
24e2d81 to
ab81474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #20676
This is a major refactoring of the parsing routines of scanf to improve the parsing of format strings and make the functions binary safe.