Use EVP_MD_CTX_destroy() instead of EVP_MD_CTX_free()
#20748
Closed
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty and consistency
Contributor
Author
|
As a reference, this was broken in PR #19563 |
ndossche
approved these changes
Dec 21, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Hm, and indeed to this date it still defines these aliases.
LGTM. Thanks.
Contributor
Author
|
Thank you for the note in the NEWS file but I really don't think it's necessary... Besides me and perhaps a handful more people in the world, nobody cares about this 😆 |
Member
Well, you still should get credit for your effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL v1.1.0 renamed
EVP_MD_CTX_(create|init|destroy)toEVP_MD_CTX_(new|reset|free)but full support for the old names is present via#defines.Moreover, in the same file and in the openssl extension the older names are still in use.
As this is the only thing breaking build of PHP 8.3 branch on legacy systems (since 8.3.26), and as there is no harm in just using the older name, just use them and let people build 😄