Fix GH-21557: jewishtojd returns 0 for years >= 6000.#21558
Closed
devnexen wants to merge 1 commit intophp:PHP-8.4from
Closed
Fix GH-21557: jewishtojd returns 0 for years >= 6000.#21558devnexen wants to merge 1 commit intophp:PHP-8.4from
devnexen wants to merge 1 commit intophp:PHP-8.4from
Conversation
The year >= 6000 upper bound introduced in phpGH-18849 was too restrictive as it is a valid year in the Jewish calendar. The overflow protection in MoladOfMetonicCycle already handles large values, the only guard needed is to prevent year + 1 from wrapping around INT_MAX.
iluuu1994
approved these changes
Mar 28, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
This falls into the "Allowing recent regression fixes during security support", so should likely target 8.3.
Allowing recent regression fixes during security support
This proposal is to allow fixes of regressions caused by other fixes merged to the supported branch in the last 12 months. The reasoning behind this is that more complex fixes will be possible later in the cycle. These fixes might potentially introduce regressions. If such a regression is found within a year, then it will be possible to apply a fix for that even if the branch allows only security fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The year >= 6000 upper bound introduced in GH-18849 was too restrictive as it is a valid year in the Jewish calendar. The overflow protection in MoladOfMetonicCycle already handles large values, the only guard needed is to prevent year + 1 from wrapping around INT_MAX.