ext/pdo_odbc: Require non-empty string when building string buffer#21652
Merged
NattyNarwhal merged 1 commit intophp:PHP-8.4from Apr 13, 2026
Merged
ext/pdo_odbc: Require non-empty string when building string buffer#21652NattyNarwhal merged 1 commit intophp:PHP-8.4from
NattyNarwhal merged 1 commit intophp:PHP-8.4from
Conversation
A buggy driver could do this and get PDO_ODBC stuck in this loop. Require a non-empty string, so an empty one breaks like the SQL_NO_DATA case. Fixes phpGH-21534
Member
Author
|
Merging because OK from Saki in comment on linked issue; working with Db2i driver in user testing and with SQL Server in CI |
NattyNarwhal
added a commit
that referenced
this pull request
Apr 13, 2026
* PHP-8.4: ext/pdo_odbc: Require non-empty string when building string buffer (#21652)
NattyNarwhal
added a commit
that referenced
this pull request
Apr 13, 2026
* PHP-8.5: ext/pdo_odbc: Require non-empty string when building string buffer (#21652)
Member
|
Yes, I was feeling unwell, so my response was delayed. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A buggy driver could do this and get PDO_ODBC stuck in this loop. Require a non-empty string, so an empty one breaks like the SQL_NO_DATA case.
Fixes GH-21534