Closed
Conversation
This is the internal API compliment to `php_random_bytes`
Member
Member
|
It's okay with me, for reasons ... we can talk about them if you like ... or we can leave it at ok ... |
Contributor
Author
|
I'm happy with "ok" ;) |
Member
|
I think it's too late for 7.0 (@weltling please confirm). Once confirm is recv'd, please rebase on appropriate branch. |
Member
|
@krakjoe its a small self contained function, I do not see a reason why this cannot go into 7.0 if it also goes into 7.1, as it may also help transition of 7.0 -> 7.1 if the function is available earlier |
Member
|
That's a good point. My early morning brain said that some of the justification for inclusion in 7.1 might not apply to 7.0, but I guess some of it does. I'd like it in 7.0 whatever. |
Contributor
Author
Contributor
|
Yeah, that's fine for 7.0. Please merge. Thanks. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the internal API compliment to
php_random_bytesThe purpose is to allow extensions and future enhancements that require high quality unbiased random numbers to fetch them without having to implement their own unbiasing algorithm.