Skip to content

curl: replace external URLs with local test server in tests #21805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordikroon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

curl: replace external URLs with local test server in tests #21805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/curl/tests/bug52202.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Bug #52202 (CURLOPT_PRIVATE gets clobbered)
curl
--FILE--
<?php
$curl = curl_init("http://www.google.com");
$curl = curl_init();
curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
curl_setopt($curl, CURLOPT_PRIVATE, "123");
curl_setopt($curl, CURLOPT_CONNECTTIMEOUT, 1);
Expand Down
13 changes: 5 additions & 8 deletions ext/curl/tests/bug64267.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,13 @@
Bug #64267 (CURLOPT_INFILE doesn't allow reset)
--EXTENSIONS--
curl
--SKIPIF--
<?php
if (getenv("SKIP_ONLINE_TESTS")) die("skip online test");
?>
--FILE--
<?php

include 'server.inc';
echo "TEST\n";

$c = curl_init("http://google.com");
$host = curl_cli_server_start();
$c = curl_init($host);
$f = fopen(__FILE__,"r");
var_dump(curl_setopt_array($c, [
CURLOPT_RETURNTRANSFER => true,
Expand All @@ -30,8 +27,8 @@ var_dump(curl_setopt_array($c, [
curl_exec($c);
var_dump(curl_getinfo($c, CURLINFO_RESPONSE_CODE));
?>
--EXPECTF--
--EXPECT--
TEST
bool(true)
bool(true)
int(30%d)
int(200)
2 changes: 1 addition & 1 deletion ext/curl/tests/bug68089.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Bug #68089 (NULL byte injection - cURL lib)
curl
--FILE--
<?php
$url = "file:///etc/passwd\0http://google.com";
$url = "file:///etc/passwd\0http://php.net";
$ch = curl_init();

try {
Expand Down
4 changes: 3 additions & 1 deletion ext/curl/tests/bug71523.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ if (curl_version()['version_number'] === 0x080a00) {
?>
--FILE--
<?php
include 'server.inc';
$host = curl_cli_server_start();

$base = curl_init('http://www.google.com/');
$base = curl_init($host);
curl_setopt($base, CURLOPT_RETURNTRANSFER, true);
$mh = curl_multi_init();

Expand Down
2 changes: 1 addition & 1 deletion ext/curl/tests/bug78775.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if (getenv('SKIP_ONLINE_TESTS')) die('skip Online test');
--FILE--
<?php

$sock = fsockopen("tls://google.com", 443);
$sock = fsockopen("tls://php.net", 443);

var_dump($sock);

Expand Down
6 changes: 3 additions & 3 deletions ext/curl/tests/curl_upkeep_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ curl_upkeep() function
curl
--SKIPIF--
<?php
if (getenv("SKIP_ONLINE_TESTS")) die("skip online test");
if (curl_version()['version_number'] < 0x073e00) die('skip requires curl >= 7.62.0');
?>
--FILE--
<?php
include 'server.inc';

$url = "https://example.com";
$host = curl_cli_server_start();

$ch = curl_init();
curl_setopt($ch,CURLOPT_URL,$url);
curl_setopt($ch,CURLOPT_URL,$host);
curl_setopt($ch,CURLOPT_RETURNTRANSFER,true);
curl_setopt($ch,CURLOPT_HTTP_VERSION,CURL_HTTP_VERSION_2_0);
curl_setopt($ch,CURLOPT_SSL_VERIFYPEER,false);
Expand Down
Loading