ext/phar: refactor phar_get_archive()#21858
Merged
Girgias merged 1 commit intophp:masterfrom Apr 29, 2026
Merged
Conversation
Girgias
force-pushed
the
2026-04-phar-remove-goto
branch
from
7beea2a to
c3dca97
Compare
Girgias
force-pushed
the
2026-04-phar-remove-goto
branch
from
c3dca97 to
de3bff3
Compare
Instead of using an out param.
Girgias
force-pushed
the
2026-04-phar-remove-goto
branch
from
de3bff3 to
04cb2b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might punt the last commit to another PR, but this should overall simplify the flow of the function and clarity.