[RFC] Friends#21937
Draft
DanielEScherzer wants to merge 4 commits intophp:masterfrom
Draft
Conversation
mvorisek
reviewed
May 3, 2026
| <?php | ||
|
|
||
| class Foo { | ||
| friend Bar; |
Contributor
There was a problem hiding this comment.
Would it make sense also to allow wildcard at the end like friend *; or Subnamespace\* or \DifferentNs\*?
Member
Author
There was a problem hiding this comment.
friend * is just making things accessible in all classes, but not outside of classes, which doesn't seem much better than just making things public
namespaces with wildcards feels like a backdoor namespace visibility, which is something being discussed separately on https://wiki.php.net/rfc/namespace_visibility
Contributor
There was a problem hiding this comment.
I meant * (not \*) to allow all classes in current namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.