Skip to content

Fix GH-22121: double-free in gdImageSetStyle() after overflow early return #22125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iliaal wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+43 −3
Open

Fix GH-22121: double-free in gdImageSetStyle() after overflow early return #22125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/gd/libgd/gd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2854,12 +2854,12 @@ int gdCompareInt (const void *a, const void *b)

void gdImageSetStyle (gdImagePtr im, int *style, int noOfPixels)
{
if (im->style) {
gdFree(im->style);
}
if (overflow2(sizeof (int), noOfPixels)) {
return;
}
if (im->style) {
gdFree(im->style);
}
im->style = (int *) gdMalloc(sizeof(int) * noOfPixels);
memcpy(im->style, style, sizeof(int) * noOfPixels);
im->styleLength = noOfPixels;
Expand Down
40 changes: 40 additions & 0 deletions ext/gd/tests/gh22121.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
--TEST--
GH-22121 (Double free in gdImageSetStyle() after overflow-triggered early return)
--EXTENSIONS--
gd
--INI--
memory_limit=-1
--SKIPIF--
<?php
if (!getenv('RUN_RESOURCE_HEAVY_TESTS')) die('skip resource-heavy test');
if (PHP_INT_SIZE < 8) die('skip 64-bit only (allocates ~10 GiB)');
function get_system_memory(): int|float|false {
if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
@exec('wmic OS get FreePhysicalMemory', $output);
if (isset($output[1])) {
return ((int)trim($output[1])) * 1024;
}
} else {
$memInfo = @file_get_contents("/proc/meminfo");
if ($memInfo && preg_match('/MemAvailable:\s+(\d+) kB/', $memInfo, $matches)) {
return $matches[1] * 1024;
}
}
return false;
}
if (get_system_memory() < 12 * 1024 * 1024 * 1024) {
die('skip Reason: Insufficient RAM (less than 12GB)');
}
?>
--FILE--
<?php
$im = imagecreatetruecolor(1, 1);
imagesetstyle($im, [0]);
imagesetstyle($im, array_fill(0, 536870912, 0));
unset($im);
echo "no double free\n";
?>
--EXPECTF--
Warning: imagesetstyle(): Product of memory allocation multiplication would exceed INT_MAX, failing operation gracefully
in %s on line %d
no double free
Loading