ext/standard: http(s) wrapper corrupts the basic auth header on perce…#22172
Open
devnexen wants to merge 2 commits into
Open
ext/standard: http(s) wrapper corrupts the basic auth header on perce…#22172devnexen wants to merge 2 commits into
devnexen wants to merge 2 commits into
Conversation
…nt-encoded userinfo. php_url_decode() returns the shorter decoded length but ZSTR_LEN() is left untouched, so smart_str_append() carries the stale [decoded][NUL][undecoded tail] bytes into the base64 credentials. Fix php#22171
Member
Author
|
the ftp wrapper, however, does it correctly. |
iluuu1994
approved these changes
May 29, 2026
|
|
||
| function probe(string $label, string $userinfo, string $expected): void | ||
| { | ||
| $responses = array( |
| $url = preg_replace('#^http://#', 'http://' . $userinfo . '@', $uri); | ||
| file_get_contents($url); | ||
|
|
||
| http_server_kill($pid); |
Member
There was a problem hiding this comment.
Not sure if it's reliable to kill the server before seeking the content, so maybe move this down?
| fseek($output, 0, SEEK_SET); | ||
| $output = stream_get_contents($output); | ||
|
|
||
| if (preg_match('/^Authorization:\s*Basic\s+(\S+)/mi', $output, $m)) { |
Member
There was a problem hiding this comment.
Nit: Inconsistent regex delimiter. I prefer (), but we should at least be consistent within the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt-encoded userinfo.
php_url_decode() returns the shorter decoded length but ZSTR_LEN() is left untouched, so smart_str_append() carries the stale [decoded][NUL][undecoded tail] bytes into the base64 credentials.
Fix #22171