ext/standard: Fix sleep and usleep unsigned integer overflow#22619
Merged
Conversation
Girgias
requested changes
Jul 6, 2026
LamentXU123
changed the title
sleep and usleep signed integer overflowsleep and usleep unsigned integer overflow
Girgias
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sleep(4294967296)actually sleep 0 seconds because of a unsigned int overflow bug, see here. This is also true inusleepI target this to master as a fix that is classified as a stricter parsing. Now we throw
ValueErrorinstead.p.s.: in Windows, the sleep function is implemented with
SleepEx(t * 1000, TRUE)not php_sleep, phew, so we need to lower the threshold to UINT_MAX / 1000