Closed
Conversation
This reverts commit b148c50 and reintroduces the fix for bug #55407. With https://wiki.php.net/rfc/parameter-no-type-variance being implemented now, it's no longer a BC break.
kelunik
referenced
this pull request
May 29, 2017
Member
Author
|
@krakjoe Fixed the failing test. |
Member
|
Just to be sure, this revert is only targeting master, right ? |
Member
Author
|
@krakjoe Yes, because https://wiki.php.net/rfc/parameter-no-type-variance is only implemented in master. |
Member
|
Merged as f2e7cdb into master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b148c50 and reintroduces the fix for bug #55407.
With https://wiki.php.net/rfc/parameter-no-type-variance being implemented now, it's no longer a BC break.