-
Notifications
You must be signed in to change notification settings - Fork 8k
Refactor AC_INIT in configure.ac and PHP versions #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f71c22a to
508fffe
Compare
|
Merge coming up this weekend or so... |
|
What is the effect of these changes on configure? |
|
Obsolete call removed and more info in the
It's how the |
Since Autoconf 2.53 the AC_INIT call with only a single argument has been made obsolete and now includes several other optional arguments to make installation experience a bit better by providing program version and links to the project in the `./configure -h` output. This patch also updates win build version.
|
@sgolemon please have a look, as this will impact your php-release docker image |
|
Worth noting, this change is done only on 7.4 branch and up... |
|
@petk if you are not aware of it, see https://github.com/sgolemon/php-release which may have some interest for you |
|
Applied via afd52f9 for PHP-7.4 and 8.0+ branches... |
|
As pointed out by @krakjoe this is likely causing build warnings for extensions: https://travis-ci.org/krakjoe/parallel/jobs/517661755#L647 |
|
Hello, let me check it out... Basically there should be some minor adjustments needed I think for the phpize part. |
Hello, since Autoconf 2.53 the
AC_INITcall has been refactored and now includes several other optional arguments to make installation experience a bit better.This patch refactors AC_INIT and PHP version definition a bit.
Reference: https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html
Some more fixes coming up soon...TODO:
get_version_numbersin win32/build/confutils.js