Declare a number of functions as variadic.#570
Declare a number of functions as variadic.#570realityking wants to merge 1 commit intophp:PHP-5.6from
Conversation
There was a problem hiding this comment.
This doesn't look quite right - shouldn't this still use ZEND_BEGIN_ARG_INFO_EX(arginfo_min, 0, 0, 1) to signify that there is one required parameter?
There was a problem hiding this comment.
Oh, I see. -1 required args is the same as requiring all args. I'd still keep the explicit form though...
There was a problem hiding this comment.
Well the majority of functions uses ZEND_BEGIN_ARG_INFO when possible so it seems like to cleaner way to go. Might be even better if we loose the now useless ,0in PHP6.
|
Merged as 417dbfb. (Without the ARG_INFO_EX -> ARG_INFO changes). Thanks for the contribution and sorry it took so long to get this merged :/ |
|
Thank you. I'm closing this, might use the parts you didn't merge for another pull request. |
2 participants
Replacement for #553, this time against PHP-5.6.
In the past there there were a number of workarounds used to signify variadic function. Now that we have a syntax for variadics and reflection support, it's time to update those functions. This covers all functions in core.
cc @nikic