Skip to content

Give a bool a bool default value.#6168

Closed
Crell wants to merge 1 commit intophp:masterfrom
Crell:json-params
Closed

Give a bool a bool default value.#6168
Crell wants to merge 1 commit intophp:masterfrom
Crell:json-params

Conversation

@Crell
Copy link
Copy Markdown
Contributor

@Crell Crell commented Sep 19, 2020

The public documentation already has a FALSE default value here, so let's keep in sync.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Sep 19, 2020

The docs are not up to date for PHP 7.2+: https://3v4l.org/1FLnX

PS: relevant commit: aa2282d

@nikic
Copy link
Copy Markdown
Member

nikic commented Sep 19, 2020

This would prevent json_decode($value, options: JSON_OBJECT_AS_ARRAY) from working.

@cmb69
Copy link
Copy Markdown
Member

cmb69 commented Sep 19, 2020

Documented the proper default value now, so this PR can be closed. Thanks for bringing this up, @Crell!

@cmb69 cmb69 closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants