Skip to content

fix [-Wstrict-prototypes] buid warnings in ext/gd #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix [-Wstrict-prototypes] buid warnings in ext/gd #7684

wants to merge 2 commits into from

Conversation

remicollet
Copy link
Member

Followup of #7683

Previous was trivial, so target 8.1
This one is more change, so target master only

@remicollet remicollet requested a review from cmb69 November 24, 2021 14:43
cmb69
cmb69 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the existing mess, this is a nice solution! Thank you!

@cmb69
Copy link
Member

cmb69 commented Nov 24, 2021

Thoughts about merging this into PHP-8.1? @krakjoe, @patrickallaert, @ramsey

@cmb69
Copy link
Member

cmb69 commented Nov 24, 2021

Minor issue: typo in commit message (buid → build)

@nikic
Copy link
Member

nikic commented Nov 24, 2021

Can we drop -Wno-strict-prototypes from GD_CFLAGS now?

@remicollet
Copy link
Member Author

despite changes are quite large, probably worth to be in 8.1

(especially as the call of gdImagePngCtxEx is broken for a long time with system libgd, but hidden by the function pointer without no prototype)

@remicollet remicollet mentioned this pull request Nov 24, 2021
Closed
@cmb69
Copy link
Member

cmb69 commented Nov 24, 2021

especially as the call of gdImagePngCtxEx is broken for a long time with system libgd, but hidden by the function pointer without no prototype

Well, not a real issue to pass surplus arguments, but better to fix it.

@remicollet
Copy link
Member Author

Can we drop -Wno-strict-prototypes from GD_CFLAGS now?

Perhaps, but the warning allow to discover a real issue (gdImagePngCtxEx call ;)

@patrickallaert
Copy link
Contributor

Thoughts about merging this into PHP-8.1? @krakjoe, @patrickallaert, @ramsey

I am ok with it, would be part of PHP 8.1.1 then.

@cmb69
Copy link
Member

cmb69 commented Nov 24, 2021

The question was whether we can drop --Wno-strict-prototypes. :) In other words, are we -W-strict-prototypes clean with this PR?

@patrickallaert
Copy link
Contributor

Can we drop -Wno-strict-prototypes from GD_CFLAGS now?

Would be a good think IMHO, yes.

@remicollet
Copy link
Member Author

remicollet commented Nov 24, 2021 •
edited
Loading

Sorry, I misunderstod @nikic question. -Wno-strict-prototypes is now removed

@remicollet remicollet mentioned this pull request Nov 25, 2021
Closed
@remicollet
Copy link
Member Author

Replaced by #7689

@remicollet remicollet closed this Nov 25, 2021
@remicollet remicollet deleted the issue-strictproto2 branch November 25, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remicollet @cmb69 @nikic @patrickallaert