Skip to content

fix gdImagePngCtxEx call with system libgd #7685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix gdImagePngCtxEx call with system libgd #7685

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Member

Minimal fix for 8.0+ extracted from pr #7684

@remicollet remicollet requested a review from cmb69 November 24, 2021 15:03
cmb69
cmb69 reviewed Nov 24, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay for me, but is there really an issue when passing surplus arguments (except that a compiler/linter might complain)?

@remicollet
Copy link
Member Author

This is okay for me, but is there really an issue when passing surplus arguments (except that a compiler/linter might complain)?

Usually, not an issue when using cdecl, may can be bad with fastcall (used in some part of Zend)

cmb69
cmb69 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, not an issue when using cdecl, may can be bad with fastcall (used in some part of Zend)

Ah, right; an issue if callee pops stack.

@remicollet
Copy link
Member Author

Applied as e713890

@remicollet remicollet closed this Nov 25, 2021
@remicollet remicollet deleted the issue-strictproto3 branch November 25, 2021 07:28
@remicollet remicollet mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remicollet @cmb69