Closed
Conversation
hwde
force-pushed
the
ext_dom_php_dom_malloc
branch
from
c92047a to
7a36f32
Compare
Contributor
|
I was just checking out this change and I did not understand what was the difference. Then I found this e-mail in the Internet and would like to share it in case someone newbie like me has the same questio. https://www.mail-archive.com/php-dev@lists.php.net/msg42335.html |
Contributor
Author
|
Oops, maybe I'm wrong with it, I want to use the "malloc" and ensure you get what you want allocation (tested against NULL). It is late ... |
Member
|
@hwde, are you planning to follow up with a fix? @juan-morales, see https://www.phpinternalsbook.com/php7/memory_management/zend_memory_manager.html for a more comprehensive explanation. |
Contributor
Author
|
I've created a new PR in #9015, because I mix up the base and used master branch here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.