Bump minimum PHP requirement for php.net sites to 5.4 #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all mirrors already use at least 5.4 versions and also the code in the repository already uses 5.4 syntax in some places, such as releases/feed.php file with __DIR__ constant. This patch syncs this state a bit.
Member
Author
|
P.S: Supported versions timeline ... |
Contributor
According to the mirror administration page (php.net account login required), a good chunk of the mirrors are still on 5.3.
That particular constant was added in 5.3.0. |
Member
Author
|
@salathe thanks for the info. Uh, I've missed that terribly. Good list for an overview of all that. |
Member
Author
|
Closing in favor of discussion on mailing lists... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all mirrors already use at least 5.4 versions and also the code in the repository already uses 5.4 syntax in some places, such as
releases/feed.phpfile with__DIR__constant.This patch syncs this state a bit.