-
Notifications
You must be signed in to change notification settings - Fork 597
Fix off by-one error. Today (Dec 2nd), it shows 'today', where it's really the last day. #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eally the last day.
|
It' s about http://php.net/supported-versions.php. It seems to me that “today” is correct here. |
|
I think it's currently ambiguous because it says "Security Support Until" in the header. That is wrong in this case, as it's "until tomorrow", not today. As that would mean that today there would not have been security support for this branch. "Until" is usually meant exclusively. Instead of my suggestion of "last day", it can also be "tomorrow" instead. |
|
Ah, I see. May we should use “midnight” then? However, it seems to me that this is somewhat moot anyway, since it is already tomorrow in some parts of the world. :) For instance, au1.php.net shows: “ |
|
Yeah, there's still the timezone issue. But that's a bit too granular I think. Being consistent is good enough. |
|
Okay, LGTM. |
|
@cmb69 I'd hoped you could merge it ;-) |
4c68142 to
5d5f117
Compare
|
Applied as 09f261e. |
|
A side note: there is now a new branch |
|
@petk — just deleted it |


No description provided.