Skip to content

Conversation

@derickr
Copy link
Member

@derickr derickr commented Dec 2, 2018

No description provided.

@cmb69
Copy link
Member

cmb69 commented Dec 2, 2018

It' s about http://php.net/supported-versions.php. It seems to me that “today” is correct here.

@derickr
Copy link
Member Author

derickr commented Dec 2, 2018

I think it's currently ambiguous because it says "Security Support Until" in the header. That is wrong in this case, as it's "until tomorrow", not today. As that would mean that today there would not have been security support for this branch. "Until" is usually meant exclusively. Instead of my suggestion of "last day", it can also be "tomorrow" instead.

@winks
Copy link

winks commented Dec 2, 2018

@cmb69 It can be read as correct if it stands on its own - but this was the original observation:

img

Also thanks, @derickr :)

@cmb69
Copy link
Member

cmb69 commented Dec 2, 2018

Ah, I see. May we should use “midnight” then? However, it seems to me that this is somewhat moot anyway, since it is already tomorrow in some parts of the world. :) For instance, au1.php.net shows: “
3 Dec 2018 | today”.

@winks
Copy link

winks commented Dec 2, 2018

Yeah, there's still the timezone issue. But that's a bit too granular I think. Being consistent is good enough.

@cmb69
Copy link
Member

cmb69 commented Dec 2, 2018

Okay, LGTM.

@derickr
Copy link
Member Author

derickr commented Dec 2, 2018

@cmb69 I'd hoped you could merge it ;-)

@php-pulls php-pulls force-pushed the security-update-off-by-one branch from 4c68142 to 5d5f117 Compare December 2, 2018 18:35
@cmb69
Copy link
Member

cmb69 commented Dec 2, 2018

Applied as 09f261e.

@petk
Copy link
Member

petk commented Dec 3, 2018

A side note: there is now a new branch security-update-off-by-one left in the web-php repository that probably should be removed :)

@php-pulls php-pulls closed this Dec 3, 2018
@php-pulls php-pulls deleted the security-update-off-by-one branch December 3, 2018 01:25
@derickr
Copy link
Member Author

derickr commented Dec 3, 2018

@petk — just deleted it

@cmb69
Copy link
Member

cmb69 commented Dec 6, 2018

Looks like we have to amend:
supported-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants