Skip to content

Redirect from inactive languages to EN (doc bug #77637) #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Redirect from inactive languages to EN (doc bug #77637) #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions error.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,17 @@
}
}

// ============================================================================
// For manual pages for inactive languages, if the EN page exists, redirect there
if (preg_match("!^manual/([^/]+)/([^/]+).php$!", $URI, $match) &&
isset($INACTIVE_ONLINE_LANGUAGES[$match[1]])) {
$try = find_manual_page("en", $match[2]);
Copy link
Contributor Author

@salathe salathe Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use $LANG instead of en here, but I figured en is always the best place to direct people.

if ($try) {
status_header(301);
Copy link
Contributor Author

@salathe salathe Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

301 is meant to be permanent, does this mean we'll have a hard time reviving inactive translations?

mirror_redirect($try);
exit;
}
}

// ============================================================================
// 404 page for manual pages (eg. not built language)
Expand Down