Remove references, redirects, and selection of mirrors #275
Conversation
salathe
left a comment
salathe
left a comment
There was a problem hiding this comment.
First, thanks for this! There are a few minor comments and things that we might want to do going forward; see my comments on a few of the individual changes. That said, on the whole this a very thorough PR. :)
There are a few other places that might be good to also update:
- download-docs.php line 112 could change
/get/$filename/from/a/mirrorto
/distributions/manual/$filename - feed.php line 52 could change
/get/{$source["filename"]}/from/this/mirrorto/distributions/{$source["filename"]}
| } else { | ||
| $download_link = "/" . $download_link; | ||
| } | ||
| $download_link = "/distributions/" . $file; |
There was a problem hiding this comment.
The *.asc file links (lines 199-208) could be treated similarly? At the moment, they still link to get/*.asc/from/a/mirror.
mirroring.php
Outdated
| In the event that such action is taken against your account, remember: | ||
| it is your responsibility. | ||
| The PHP project does no have an official mirror program anymore, but you can | ||
| set-up a mirror for your own network or company. |
There was a problem hiding this comment.
This file retains several references to official mirrors and their setup (e.g. using cc.php.net). The entire document could do with a thorough review after this first sweep of changes to the site.
| <?php | ||
| site_footer(); | ||
| header("HTTP/1.1 301 Moved Permanently"); | ||
| header("Location: /"); |
There was a problem hiding this comment.
The mirrors.php page is linked from thanks.php. It might be nice to include a big thank you to all of our mirror providers in thanks.php, but in any case the link to mirrors.php on that page will be broken now.
php-pulls
force-pushed
the
get-rid-of-the-mirrors
branch
from
ff2fc48 to
7075f94
Compare
|
@derickr is it also ok with you to remove the stalled branch |
|
Oh sure. I had forgotten. I've deleted it now. |
This removes the use of mirrors across php.net, and moves everything to https.