Removed dead information from Readme #306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed PHP 5.3 (!) requirement from readme, replaced with 7.3
cmb69
reviewed
Dec 11, 2019
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thanks! LGTM, except for the PHP version requirement. It seems the site is currently running on 7.2, so that should probably be used as minimum requirement.
Author
As 7.2 is in security-only should we stick a pin in it and wait for someone to upgrade to 7.4, or just reference 7.2? |
Member
|
I would just reference 7.2 for now. |
Member
|
Thanks! Applied as 8b832da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed official mirrors from readme, there are no official mirrors anymore.
Removed PHP 5.3 (!) requirement from readme, replaced with 7.3