Fixed ridiculous example #357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
reviewed
Nov 26, 2020
| <div class="php8-code phpcode"> | ||
| <?php highlight_php_trimmed( | ||
| '/** | ||
| * @Route("/api/posts/{id}", methods={"GET", "HEAD"}) |
There was a problem hiding this comment.
a simpler fix would have been changing api/posts/{id} to api/users 🤔
Contributor
Author
There was a problem hiding this comment.
And changing User -> UsersController?)
Contributor
Author
There was a problem hiding this comment.
All the same we need to present method's attribute when we using Route annotation.
Controller's action is most popular example instead of separated action's action.
There was a problem hiding this comment.
actually, it can be applied to both at the same time, and this is not a real application, it's only an example to show the new syntax, and is not referring to a specific library/framework.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now class
Userprocesses the routing for posts action 😀I've fixed ridiculoues example of routing classes 👍