Skip to content

Conversation

@gunnard
Copy link

@gunnard gunnard commented Nov 28, 2020

@cmb69
Copy link
Member

cmb69 commented Nov 28, 2020

Thanks for the PR, but I don't think this is an appropriate solution, because it may distort the images (consider a 400px * 400px image). And even if we avoid distorted images, why send large images to the browser, when we only want to show a certain size? Okay, would make sense for displays with high density, but if we wanted to cater to that, we probaly should use srcset or such. OTOH, I don't see a real issue with the way it's currently handled: just don't commit overly large images.

@gunnard
Copy link
Author

gunnard commented Nov 28, 2020 via email

@gunnard gunnard closed this Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants