Skip to content

Conversation

@tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Nov 28, 2020

It might be a good idea to translate the language switcher so people don't have to know English to find their language in it.

@tvlooy tvlooy mentioned this pull request Nov 28, 2020
@sgolemon
Copy link
Member

+1 on doing this from me. It didn't quite sit right that these should be anglified.

'de' => 'Deutsch',
'es' => 'Español',
'fr' => 'Français',
'pt_BR' => 'Português do Brasil',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you changed the order as well, but I'm not going to worry about that for now. IMO we should probably asort() this whole thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, asort() would be better :)

@php-pulls
Copy link

Comment on behalf of pollita at php.net:

Merged as 290632d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants