Use own language selection for PHP 8 release page #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general language selection capability of php.net is nice, but it does not allow to have translations of the PHP 8 release page which do not have active doc translations. To circumvent this limitation, we use an own super simple language selection capability for the PHP 8 release page. We do not even bother to support non JS enabled clients, since that was not supported before, although it could be done.
kallesommernielsen
approved these changes
Nov 30, 2020
sgolemon
approved these changes
Dec 2, 2020
Member
sgolemon
left a comment
sgolemon
left a comment
There was a problem hiding this comment.
Nice and practical solution.
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general language selection capability of php.net is nice, but it
does not allow to have translations of the PHP 8 release page which do
not have active doc translations. To circumvent this limitation, we
use an own super simple language selection capability for the PHP 8
release page. We do not even bother to support non JS enabled clients,
since that was not supported before, although it could be done.