Skip to content

Conversation

@mikeschinkel
Copy link
Contributor

As get_magic_quotes_gpc() has been removed in PHP 8.0, this PR removes it from the clean() function in layout.inc.

Hopefully its removal is valid, or at least how it was removed it valid.

As get_magic_quotes_gpc() has been removed in PHP 8.0, this PR removes it from the clean() function in layout.inc.
@mikeschinkel
Copy link
Contributor Author

@tiffany-taylor — This PR should fix the mailing list submit form problem, assuming it is acceptable security wise?

(I haven't had to deal with much magic quotes/strip slashes code in PHP so I am not 100% sure if what I did is ok.)

Also, here is the email I sent to the php.webmaster list referencing this PR:

https://news-web.php.net/php.webmaster/29448

@tiffany-taylor
Copy link
Member

I will try to review this over the weekend. My computer is unplugged at present, but I'll be hooking it back up if not tomorrow, then by Saturday.

@mikeschinkel
Copy link
Contributor Author

Thanks @tiffany-taylor.

Actually thanks to @ramsey's email I looked again and don't think this was it, although this is needed.

Instead I think it was using HTTP for the URL instead of HTTPS. Here's the PR for that.

@cmb69
Copy link
Member

cmb69 commented Jul 23, 2021

This change is still needed for PHP 8 compatibility, and causes no issues if the server is running PHP 5.4+ (what I guess it does). The space in front of $var should be removed though.

@mikeschinkel
Copy link
Contributor Author

@cmb69 — Space removed.

@cmb69
Copy link
Member

cmb69 commented Jul 23, 2021

Thank you!

@cmb69 cmb69 merged commit 01337ed into php:master Jul 23, 2021
@mikeschinkel mikeschinkel deleted the remove-magic-quotes branch July 23, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants