Add json endpoint to PHP releases list #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustments We usually warn PHP users to avoid unserialize remote or untrusted data but at the same time php.net only offers a serialized endpoint for PHP releases. This commit: - adds a JSON endpoint that can be an option to avoid the serialized endpoint - sets a proper Content-Type response header for both serialized - `text/plain` - and json - `application/json` - endpoints - simplifies URLs exchanging `&serialize=1` and `&json=1` for `&serialize` and `&json` respectively
These variables were removed in 470fc09, since 5.3 is no longer an active release.
bjori
added a commit
that referenced
this pull request
Apr 6, 2015
Add json endpoint to PHP releases list * ramsey/releases-json: Change the paragraphs in the sidebar to a list. Adding clarity to the variable names for the JSON/serialized output Simplify code according to @bjori's comment Remove $PHP_5_3_* variables causing notices add json_encode()ded endpoint to PHP releases list + content type adjustments
Member
|
Thanks! |
Contributor
|
@ramsey great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies @marcioAlmada's pull request (#53), additionally cleaning it up, as requested by @bjori in #53 (diff).
I believe this would also help take care of phpbrew/phpbrew#376
This closes #53