Conversation
With this new column, users can add their own data and set this column to a non-zero value to allow simple filtering.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 99.85% 99.73% -0.13%
==========================================
Files 12 12
Lines 710 751 +41
==========================================
+ Hits 709 749 +40
- Misses 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To start with we will use json format and only allow columns that match those that already exist in the table.
The function call has been updated to the allow a variety of types to be passed in as the data. This helps with testing, but also makes sense as a thing to do so it isn't just to avoid refactoring.
Cloning the repo is not enough, you actually need to install. Add the table year to the output so the data matches the description.
The big table of data with values for gold is too dominant in the README file so update to an atom with less isotopes.
We allowed this by type hinting, but would fail if it actually happened. Update function and tests so raw string can be used.
Show examples of how user data can be added to the main dataframe.
We want to be as flexible as possible so don't want to be too limiting on how the user can interact with the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start working on #20