Treat leading $variable as a valid @see reference#456
Open
lacatoire wants to merge 2 commits intophpDocumentor:6.xfrom
Open
Treat leading $variable as a valid @see reference#456lacatoire wants to merge 2 commits intophpDocumentor:6.xfrom
lacatoire wants to merge 2 commits intophpDocumentor:6.xfrom
Conversation
Previously `@see $varname` failed FQSEN resolution and was surfaced as an InvalidTag (and in the PHP 8.0/8.1 versions mentioned in phpDocumentor#335 it even aborted parsing). The `See` factory now detects a bare variable identifier and wraps it in a new `Reference\\Variable` alongside the existing `Reference\\Fqsen` and `Reference\\Url`, so global-variable references survive parsing and round-trip. Fixes phpDocumentor#335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
@see $varnamefailed FQSEN resolution and was surfaced as anInvalidTag. TheSeefactory now detects a bare variable identifier and wraps it in a newReference\\Variablealongside the existingReference\\FqsenandReference\\Url, so global-variable references survive parsing and round-trip through__toString.Fixes #335