Micro optimizations #1248
Merged
Micro optimizations #1248
+185
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linawolf
approved these changes
Sep 21, 2025
Contributor
linawolf
left a comment
linawolf
left a comment
There was a problem hiding this comment.
This looks good to me, thank you!
- array_walk is slower than a foreach, so buffer now uses foreach. - By caching some of the inline node parsers we can strip out about 9% of the overhead in the inline parser, as we do not have to check them for every token.
By sorting every call, we are just pumping up the system. There is no need to do this, only when we need the files.
jaapio
force-pushed
the
optimizations
branch
2 times, most recently
from
70c6073 to
2d90f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the overhead in the inline parser, as we do not have to check them for every token.