Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues specifying allowed elements in the sanitizer config. I think the config is broken as-is. So I copy pasted the config from Symfony's FrameworkBundle and made it work with the guides extension instead.
Meanwhile, I also made it a bit nicer for non-XML config (they can now use array keys instead of the
nameoption).I'm not sure why the Guides extension allows specifying multiple sanitizer configs and then setting one name as the sanitizer to use. What is the use case of these other sanitizers? If we only use one sanitizer, I suggest simplifying the config by removing the multiple sanitizer variant.
At last, I added a minimal test to verify the config works. During this test, I discovered the usage of a
vendor_dirparameter. This couples the DI config to Composer's vendor directory conventions and package names. I replaced them with a relative import, which are relative to the config file location. In a future version of guides-cli, you may want to deprecate thevendor_dirparameter.