Skip to content

[TASK] Use static:: instead of self:: #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samtuke merged 1 commit into from
Feb 8, 2018
Merged

[TASK] Use static:: instead of self:: #87

samtuke merged 1 commit into from
Feb 8, 2018

Conversation

@oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Feb 7, 2018

This will allow for subclasses to overwrite methods and constants and hence
is the current recommended practice.

[TASK] Use static:: instead of self::
19eb0b4 
This will allow for subclasses to overwrite methods and constants and hence
is the current recommended practice.
@oliverklee oliverklee added this to the 4.0.0 phase 3 milestone Feb 7, 2018
@oliverklee oliverklee self-assigned this Feb 7, 2018
@oliverklee oliverklee requested a review from samtuke February 7, 2018 16:15
@samtuke samtuke merged commit 17d227a into master Feb 8, 2018
@samtuke samtuke deleted the cleanup/static branch February 8, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samtuke samtuke samtuke approved these changes

Assignees

@oliverklee oliverklee

Labels

cleanup

Projects

None yet

Milestone

4.0.0 phase 3

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverklee @samtuke