Skip to content

[TASK] Use the renamed phplist/core package #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtuke merged 1 commit into from
Feb 21, 2018
Merged

[TASK] Use the renamed phplist/core package #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ before_script:
echo "Creating the database and importing the database schema";
mysql -e "CREATE DATABASE ${PHPLIST_DATABASE_NAME};";
mysql -u root -e "GRANT ALL ON ${PHPLIST_DATABASE_NAME}.* TO '${PHPLIST_DATABASE_USER}'@'%';";
mysql ${PHPLIST_DATABASE_NAME} < vendor/phplist/phplist4-core/Database/Schema.sql;
mysql ${PHPLIST_DATABASE_NAME} < vendor/phplist/core/Database/Schema.sql;

script:
- >
Expand Down Expand Up @@ -81,9 +81,9 @@ script:
- >
echo;
echo "Running PHPMD";
vendor/bin/phpmd src/ text vendor/phplist/phplist4-core/Configuration/PHPMD/rules.xml;
vendor/bin/phpmd src/ text vendor/phplist/core/Configuration/PHPMD/rules.xml;

- >
echo;
echo "Running PHP_CodeSniffer";
vendor/bin/phpcs --standard=vendor/phplist/phplist4-core/Configuration/PhpCodeSniffer/ src/ tests/;
vendor/bin/phpcs --standard=vendor/phplist/core/Configuration/PhpCodeSniffer/ src/ tests/;
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
- REST action for getting all subscribers for a list (#83)

### Changed
- Use the renamed phplist/core package (#97)
- Adopt more of the default Symfony project structure (#92, #93, #94, #95)

### Deprecated
Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ phpList is an open source newsletter manager.

This module is the REST API for phpList 4, providing functions for superusers
to manage lists, subscribers and subscriptions via REST calls. It uses
functionality from the `phplist/phplist4-core` module (the phpList 4 core).
functionality from the `phplist/core` module (the phpList 4 core).
It does not contain any SQL queries, uses functionality from the new core for
DB access.

Expand All @@ -40,7 +40,8 @@ which also has more detailed installation instructions in the README.

You can try out the API using pre-prepared requests and the Postman GUI
tool. Install Postman as a browser extension or stand-alone app, open the
[phpList 4 REST API Demo collection](https://documenter.getpostman.com/view/3293511/phplist-4-rest-api-demo/RVftkC9t#4710e871-973d-46fa-94b7-727fdc292cd5) and click 'Run in Postman'.
[phpList 4 REST API Demo collection](https://documenter.getpostman.com/view/3293511/phplist-4-rest-api-demo/RVftkC9t#4710e871-973d-46fa-94b7-727fdc292cd5)
and click "Run in Postman".


## Contributing to this package
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"require": {
"php": "~7.0.0 || ~7.1.0 || ~7.2.0",

"phplist/phplist4-core": "4.0.x-dev",
"phplist/core": "4.0.x-dev",
"friendsofsymfony/rest-bundle": "^2.2",

"roave/security-advisories": "dev-master"
Expand Down Expand Up @@ -86,7 +86,7 @@
"symfony-var-dir": "var",
"symfony-web-dir": "public",
"symfony-tests-dir": "tests",
"phplist/phplist4-core": {
"phplist/core": {
"bundles": [
"FOS\\RestBundle\\FOSRestBundle",
"PhpList\\RestBundle\\PhpListRestBundle"
Expand Down