CS fixes

Author: dantleech

lib/Core/Diagnostics/DiagnosticsEngine.php

@@ -14,6 +14,7 @@
 use Throwable;
 use function Amp\asyncCall;
 use function Amp\delay;
+use Exception;
 
 class DiagnosticsEngine
 {
@@ -117,7 +118,7 @@ public function run(CancellationToken $token): Promise
                             $message = sprintf('Diagnostic provider "%s" errored with "%s", removing from pool', $providerId, $e->getMessage());
                             $this->clientApi->window()->showMessage()->warning($message);
                             $this->logger->error($message, [
-                                'stack' => (new \Exception())->getTraceAsString()
+                                'stack' => (new Exception())->getTraceAsString()
                             ]);
                             $crashedProviders[$providerId] = true;
                             return;

tests/Unit/Core/Diagnostics/DiagnosticsEngineTest.php

@@ -16,6 +16,7 @@
 use function Amp\asyncCall;
 use function Amp\call;
 use function Amp\delay;
+use Exception;
 
 class DiagnosticsEngineTest extends AsyncTestCase
 {
@@ -142,8 +143,8 @@ public function testHandlesLinterExceptions(): Generator
     {
         $tester = LanguageServerTesterBuilder::create();
         $engine = new DiagnosticsEngine($tester->clientApi(), new NullLogger(), [
-            new ClosureDiagnosticsProvider(function (TextDocumentItem $item) {
-                throw new \Exception('oh dear');
+            new ClosureDiagnosticsProvider(function (TextDocumentItem $item): void {
+                throw new Exception('oh dear');
             }),
         ], 10);